[Patchew-devel] [PATCH 01/12] testing: remove dead code
Paolo Bonzini
pbonzini at redhat.com
Tue May 22 06:57:29 UTC 2018
Fixes issue #72.
---
mods/testing.py | 12 ------------
tests/test_testing.py | 2 --
2 files changed, 14 deletions(-)
diff --git a/mods/testing.py b/mods/testing.py
index 24841f1..cafe9a2 100644
--- a/mods/testing.py
+++ b/mods/testing.py
@@ -59,10 +59,6 @@ class TestingModule(PatchewModule):
BooleanSchema("enabled", "Enabled",
desc="Whether this test is enabled",
default=True),
- StringSchema("users", "Users",
- desc="List of allowed users to run this test"),
- StringSchema("testers", "Testers",
- desc="List of allowed testers to run this test"),
StringSchema("requirements", "Requirements",
desc="List of requirements of the test"),
IntegerSchema("timeout", "Timeout",
@@ -256,10 +252,6 @@ class TestingModule(PatchewModule):
})
return ret
- def _build_message_prop_url(message, prop):
- return reverse("testing-get-prop",
- kwargs={"project_or_series": obj.message_id})
-
def rest_results_hook(self, request, obj, results, detailed=False):
for pn, p in obj.get_properties().items():
if not pn.startswith("testing.report."):
@@ -410,10 +402,6 @@ class TestingGetView(APILoginRequiredView):
if obj.get_property("testing.report." + tn):
done_tests.add(tn)
continue
- if t.get("tester") and tester != t["tester"]:
- continue
- if t.get("user") and user.username != t["user"]:
- continue
# TODO: group?
ok = True
reqs = t.get("requirements", "")
diff --git a/tests/test_testing.py b/tests/test_testing.py
index 3dcb505..73d13f1 100755
--- a/tests/test_testing.py
+++ b/tests/test_testing.py
@@ -22,8 +22,6 @@ def create_test(project, name):
project.set_property(prefix + "enabled", True)
project.set_property(prefix + "script", "#!/bin/bash\ntrue")
project.set_property(prefix + "requirements", "")
- project.set_property(prefix + "users", "")
- project.set_property(prefix + "tester", "")
class TestingTestCase(PatchewTestCase, metaclass=abc.ABCMeta):
--
2.17.0
More information about the Patchew-devel
mailing list