[Patchew-devel] [PATCH 00/16] RFC: Queue, MAINTAINERS and watched query

[Paolo Bonzini]

On 21/11/18 03:08, Fam Zheng wrote:
> I refreshed my queue branch from a year ago, in a slightly different way. This
> more or less makes it possible to realize what Markus asked for: watch for
> patches touching certain files (as indicated by MAINTAINERS file) and
> automatically notify him if not already in Cc.
> 
> The user story basically consists of four parts.
> 
> 1) A logged in user creates a "watched query", by accessing (once we merge this)
>    http://next.patchew.org/search?q=maint%3Ame+%21cc%3Ame and clicking the "Watch
>    query" button. The search query will be saved for the user in the database.
> 
> 2) Once a new patchset is uploaded by the importer, and post-processed by the
>    applier, which also collects the associated maintainers by invoking
>    .scripts/get_maintainer.pl.
> 
> 3) The watched query is run against this new patchset. If it is included in the
>    query, it is automatically added to the user's queue named 'watched'.
> 
> 4) An event is generated upon the addition, which is configured as a source for
>    email notifications just like testing reports. In the template, To/Cc addr
>    of the original message is tested. Depending on if or not the user's email
>    is in it, an email from no-reply at patchew.org to the user's address is sent,
>    in reply to the original message, to catch attention from the users INBOX.

Can you explain how this part would be configured?  Especially the
"depending if or not the user's email is in it" part.

> What is missing is the isolation between the existing maintainers role that
> takes care of the testings etc, and the new maintainer role that is only
> interested in receiving above notifications.

Why is there a conflict?  I understand that the new functionality is for
any logged-in user, including getting email.  As long as there Maybe
it's just a naming issue?

Perhaps one possibility is removing merged patches from the special
queues (accept/reject/watch), using a MessageMerged event.  Also adding
an "empty queue" button to the "my queues" page.  Otherwise looks great.

> Do we want the applier to create and maintain a git tree/tag for each queue?

Maybe later, but it's not required.

> What kind of user facing commands do we want on patchew-cli? Downloading and
> applying a queue?

As a start, even just listing the git tags should be enough for the user
to script it.  Maybe a generic "formatted search" like "git log
--pretty=format:..."?

But overall: it's awesome. :)

Paolo