[Patchew-devel] [PATCH v3] add more indices to Message
Paolo Bonzini
pbonzini at redhat.com
Wed Oct 31 18:32:12 UTC 2018
Add indices to help the series list page. The project is almost always
used as a search key, either directly or through a parent project, so
include both a variant with the project and one without. The sorting
keys are left last, while filter keys should come first.
This reduces the SELECT COUNT(*) query in the series list from 180 ms
to 5 ms on a full dump from a few weeks ago.
Signed-off-by: Paolo Bonzini <pbonzini at redhat.com>
---
api/migrations/0037_auto_20181031_1439.py | 19 +++++++++++++++++++
api/models.py | 4 ++++
tests/test_import.py | 6 ++++--
3 files changed, 27 insertions(+), 2 deletions(-)
create mode 100644 api/migrations/0037_auto_20181031_1439.py
diff --git a/api/migrations/0037_auto_20181031_1439.py b/api/migrations/0037_auto_20181031_1439.py
new file mode 100644
index 0000000..ca75e37
--- /dev/null
+++ b/api/migrations/0037_auto_20181031_1439.py
@@ -0,0 +1,19 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.11.15 on 2018-10-31 14:39
+from __future__ import unicode_literals
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+ dependencies = [
+ ('api', '0036_populate_message_tags'),
+ ]
+
+ operations = [
+ migrations.AlterIndexTogether(
+ name='message',
+ index_together=set([('is_series_head', 'project', 'date'), ('is_series_head', 'date'), ('is_series_head', 'last_reply_date'), ('is_series_head', 'project', 'last_reply_date')]),
+ ),
+ ]
diff --git a/api/models.py b/api/models.py
index ab0bd06..09758f6 100644
--- a/api/models.py
+++ b/api/models.py
@@ -714,6 +714,10 @@ class Message(models.Model):
class Meta:
unique_together = ('project', 'message_id',)
+ index_together = [('is_series_head', 'project', 'last_reply_date'),
+ ('is_series_head', 'project', 'date'),
+ ('is_series_head', 'last_reply_date'),
+ ('is_series_head', 'date')]
class MessageResult(Result):
message = models.ForeignKey(Message, related_name='results')
diff --git a/tests/test_import.py b/tests/test_import.py
index 5693d7e..64d8c66 100755
--- a/tests/test_import.py
+++ b/tests/test_import.py
@@ -91,8 +91,10 @@ class ImportTest(PatchewTestCase):
self.assertTrue(s.project.name, sp.name)
self.cli_import("0020-libvirt.mbox.gz")
- subj2 = subj + '\n[libvirt] [PATCH v2] vcpupin: add clear feature'
- self.check_cli(["search", "project:Libvirt"], stdout=subj2)
+ # the order of the search results may change, so we cannot use stdout=...
+ a, b = self.check_cli(["search", "project:Libvirt"])
+ self.assertEqual(sorted(a.split('\n')),
+ ['[libvirt] [PATCH v2] vcpupin: add clear feature', subj])
self.check_cli(["search", "project:Libvirt-python"], stdout=subj)
class UnprivilegedImportTest(ImportTest):
--
2.17.1
More information about the Patchew-devel
mailing list