[Patchew-devel] [PATCH] models: return None from MessageManager query methods

[Paolo Bonzini]

On 19/03/19 06:28, Fam Zheng wrote:
>>      def find_series(self, message_id, project_name=None):
>> -        return self.series_heads(project_name).filter(message_id=message_id).first()
>> +        heads = self.series_heads(project_name)
>> +        if not heads:
>> +            return None
>> +        try:
>> +            return heads.filter(message_id=message_id).first()
>> +        except Message.DoesNotExist:
>> +            return None
>> +
>>  
>>      def find_message(self, message_id, project_name):
>> -        return self.project_messages(project_name).filter(message_id=message_id).first()
>> +        messages = self.project_messages(project_name)
>> +        if not messages:
>> +            return None
>> +        try:
>> +            return messages.filter(message_id=message_id).first()
> 
> For above two: does first() throw DoesNotExist at all? If not, all
> except: are not necessary by using first().

Good point.  We still need  to check for None, but no try/except is
necessary.

Paolo