[Patchew-devel] Failure to submit patches, two questions - what should I do?

Lucien Anti-Spam lucienmp_antispam at yahoo.com
Sun May 26 08:09:18 UTC 2019


 

   > On Sunday, May 26, 2019, 4:45:26 PM GMT+9, <no-reply at patchew.org> wrote: > Subject; [Qemu-devel] [PATCH] Incorrect Stack Pointer shadow register support on some m68k CPUs > .....> snip> .....> === OUTPUT BEGIN ===
> ERROR: Author email address is mangled by the mailing list
> #2: 
> Author: Lucien Murray-Pitts via Qemu-devel <qemu-devel at nongnu.org>
> 
> WARNING: Block comments use a leading /* on a separate line
> #46: FILE: target/m68k/cpu.h:465:
> +/* The ColdFire core ISA is a RISC-style reduction of the 68000 series
> 
> WARNING: Block comments use * on subsequent lines
> #47: FILE: target/m68k/cpu.h:466:> 
> +/* The ColdFire core ISA is a RISC-style reduction of the 68000 series
> +  Whilst the 68000 flourished by adding extended stack/instructions in>.........> snip
Q1:  Name mangling seems to be a bug, whats going on - how should I be submiting now?        ( perl script didnt catch it AND there seems to already be a patch from half year or more ago .. https://patchwork.kernel.org/patch/10662525/ )  whats the correct action here?
Q2:  I am getting a WARNING but I believe it is an exception in this case.        yes I know it breaks the coding style BUT this coding style was already there for these comments.        Should I submit this patch with a move to the RIGHT coding style? or will this patch be accepted as the code is older style?


  
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/patchew-devel/attachments/20190526/045c8fa3/attachment.htm>


More information about the Patchew-devel mailing list