[Patchew-devel] [PATCH 7/9] omit Based-on from downloaded mbox

[Philippe Mathieu-Daudé]

On 1/16/20 4:09 PM, Paolo Bonzini wrote:
> The Based-on tag is internal and the information it includes is already
> accessible from the git base.  Do not include it in downloaded mboxes,
> so that it is not committed to git for no-cover-letter series.
> 
> Signed-off-by: Paolo Bonzini <pbonzini at redhat.com>
> ---
>   api/migrations/0056_repopulate_series_head.py | 4 +---
>   api/models.py                                 | 2 +-
>   2 files changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/api/migrations/0056_repopulate_series_head.py b/api/migrations/0056_repopulate_series_head.py
> index 8ffd266..2c2251c 100644
> --- a/api/migrations/0056_repopulate_series_head.py
> +++ b/api/migrations/0056_repopulate_series_head.py
> @@ -13,6 +13,4 @@ def series_head_fill(apps, schema_editor):
>   class Migration(migrations.Migration):
>       dependencies = [("api", "0055_auto_20200116_1034")]
>   
> -    operations = [
> -        migrations.RunPython(migrations.RunPython.noop, reverse_code=series_head_fill)
> -    ]
> +    operations = [migrations.RunPython(migrations.RunPython.noop, reverse_code=series_head_fill)]

Left-over from patch#5/9?

> diff --git a/api/models.py b/api/models.py
> index ab122e6..6ae2bae 100644
> --- a/api/models.py
> +++ b/api/models.py
> @@ -635,7 +635,7 @@ class Message(models.Model):
>   
>               # If no --- line, tags go at the end as there's no better place
>               for tag in sorted(tags):
> -                if tag not in old_tags:
> +                if tag not in old_tags and not tag.startswith("Based-on"):

Reviewed-by: Philippe Mathieu-Daudé <philmd at redhat.com>

>                       yield tag
>               if need_minusminusminus:
>                   yield line
>