[PatternFly] [patternfly-react] Some thoughts and a question :-)

Sat May 13 17:45:35 UTC 2017

Hey Vojtech,

This is awesome, we are definitely interested at taking a look at the work
done already and seeing if PatternFly can leverage some of that work. We
will want to do a design and dev review of the components to ensure that
they adhere to PatternFly standards. There is an open PR that defines what
that means here: https://github.com/patternfly/patternfly-react/pull/10

I'm having a hard time reviewing the components because I don't see any
test pages demonstrating the look and behavior of the components. The
PatternFly-React project has been using React Storybook to test and demo
new React UI components. There are some additional details about how to use
Storybook here:
https://github.com/patternfly/patternfly-react/blob/master/README.md

I'll defer to Patrick regarding including jQuery + D3 + C3 as
patternfly-react dependencies.

Lastly, I know there will be another PatternFly-React Community meeting in
the coming weeks that Patrick Riley is coordinating. Some of the topics
here might be interesting to add to the agenda.

Thanks,
Leslie

On Fri, May 12, 2017 at 2:26 PM, Vojtech Szocs <vszocs at redhat.com> wrote:

> Hi everyone,
>
> I've checked out https://github.com/patternfly/patternfly-react/ and
> looks like I'm late to the party :D
>
> I saw the discussion at https://github.com/patternfly/
> patternfly-react/issues/6 and posted some ideas there. I believe that
> exposing UI components as vanilla ES6 code is preferable for most projects
> and such components should be really small & simple (or composite),
> accepting data and callbacks as needed, with the usual top-down flow.
> webpack + Babel can be used to transpile <anything_beyond_es6> to vanilla
> ES6 (for example, if you decide to introduce Flow in your project).
>
> There's also a discussion whether or not to use react-bootstrap (supports
> Bootstrap v3) and if so, whether the wrapper component should extend the
> existing one or simply work on top of local copy of it. I generally agree
> with others who say that reusing react-bootstrap will save you time and
> keep up with upstream changes, maybe consider an approach where you
> identify the need for extension/customization and open issue (or even PR)
> on react-bootstrap if that happens.
>
> Also, a question - in oVirt Dashboard, we implemented some UI components
> in React, including [1]:
>
> * <RenderInto> to give you control where the given components get
> rendered, we use this for modals rendered right into HTML <body> element
>   https://gerrit.ovirt.org/gitweb?p=ovirt-engine-
> dashboard.git;a=blob;f=src/components/helper/RenderInto.jsx;hb=HEAD
>
> * basic <ModalDialog> and <Tooltip> based on jQuery
>   https://gerrit.ovirt.org/gitweb?p=ovirt-engine-
> dashboard.git;a=tree;f=src/components/bootstrap;hb=HEAD
>
> * PatternFly basics such as <DonutChart>, <SparklineChart> and <HeatMap>
> using jQuery with D3/C3
>   https://gerrit.ovirt.org/gitweb?p=ovirt-engine-
> dashboard.git;a=tree;f=src/components/patternfly;hb=HEAD
>
> * PatternFly composites such as <AggregateStatusCard> and
> <UtilizationTrendCard>
>   https://gerrit.ovirt.org/gitweb?p=ovirt-engine-
> dashboard.git;a=tree;f=src/components;hb=HEAD
>
> [1] some screenshots at http://www.ovirt.org/documentation/admin-guide/
> chap-System_Dashboard/
>
> Question - which ones do you think are worth contributing to
> patternfly-react at this point? (I saw one issue for Tooltip component, can
> we go ahead and contribute ours?)
>
> Another question - some Bootstrap based components use jQuery (like
> Tooltip) while some PatternFly specific ones (like HeatMap) have reference
> impl's in D3/C3. So I guess that adding jQuery + D3 + C3 to
> patternfly-react dependencies is something you would approve?
>
> Thanks & have a great weekend!
> Vojtech
> 
>
> _______________________________________________
> PatternFly mailing list
> PatternFly at redhat.com
> https://www.redhat.com/mailman/listinfo/patternfly
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/patternfly/attachments/20170513/5e27e9f2/attachment.htm>