[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[PATCH (non-code)] nptl-0.12: spell-check name and expand comment


Thanks for including the i586 code. I noticed two things about it,

First, in the ChangeLog, my first name is spelled wrong. Probably my
fault, as I tend to make typos in my mail-address.

Second, I tried to leave a hint about cmpxchg8b not being available on
pre-Pentiun processors. That comment change seems to have been
lost. This is a new try, in different words, as it was't very clear

diff -Nur nptl-0.12-orig/ChangeLog nptl/ChangeLog
--- nptl-0.12-orig/ChangeLog	2002-12-08 10:41:00.000000000 +0100
+++ nptl/ChangeLog	2002-12-08 10:42:18.000000000 +0100
@@ -101,7 +101,7 @@
 	include i486 version.
 	* sysdeps/i386/i486/pthread_spin_trylock.S: New file.
 	* sysdeps/i386/i586/pthread_spin_trylock.S: New file.
-	Patch by Marjin Ros <marjin mad scientist com>.
+	Patch by Marijn Ros <marijn mad scientist com>.
 	* allocatestack.c (get_cached_stack): Don't crash if we first
 	found a stack with a larger size then needed.
diff -Nur nptl-0.12-orig/sysdeps/i386/i486/bits/atomic.h nptl/sysdeps/i386/i486/bits/atomic.h
--- nptl-0.12-orig/sysdeps/i386/i486/bits/atomic.h	2002-12-08 10:40:59.000000000 +0100
+++ nptl/sysdeps/i386/i486/bits/atomic.h	2002-12-08 10:44:49.000000000 +0100
@@ -80,7 +80,8 @@
    not in the moment.  Using it would mean causing portability
    problems since not many other 32-bit architectures have support for
    such an operation.  So don't define any code for now.  If it is
-   really going to be used the code below can be used.  */
+   really going to be used the code below can be used on Intel Pentium
+   and later, but NOT on i486.  */
 #if 1
 # define __arch_compare_and_exchange_64_acq(mem, newval, oldval) \
   (abort (), 0)

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]