[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: nptl 0.49



Hello Ulrich

First, big thanks about the pthread_cond improvements.

I have a remark about the use of FUTEX_REQUEUE

If the linux kernel is not FUTEX_REQUEUE aware, I think the syscall returns
ENOSYS and not EINVAL .

I suggest this change :

diff -u nptl/sysdeps/unix/sysv/linux/i386/i486/pthread_cond_signal.S
nptl-next/sysdeps/unix/sysv/linu
x/i386/i486/pthread_cond_signal.S
--- nptl/sysdeps/unix/sysv/linux/i386/i486/pthread_cond_signal.S
2003-06-26 06:03:54.000000000 +0200
+++ nptl-next/sysdeps/unix/sysv/linux/i386/i486/pthread_cond_signal.S
2003-06-26 06:02:42.000000000 +0200
@@ -34,7 +34,6 @@
 #define FUTEX_REQUEUE          3

 #define EINVAL                 22
+#define        ENOSYS          38      /* Function not implemented */


        .text
@@ -86,7 +85,7 @@
        ENTER_KERNEL

 #ifndef __ASSUME_FUTEX_REQUEUE
-       cmpl    $-EINVAL, %eax
+       cmpl    $-ENOSYS, %eax
        je      7f
 #endif

and similar changes to other files.

See you

Eric Dumazet

----- Original Message ----- 
From: "Ulrich Drepper" <drepper redhat com>
To: "NPT library mailing list" <phil-list redhat com>
Sent: Wednesday, June 25, 2003 7:37 AM
Subject: nptl 0.49


> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> New sources at
>
>   http://people.redhat.com/drepper/nptl/nptl-0.49.tar.bz2
>    ftp://people.redhat.com/drepper/nptl/nptl-0.49.tar.bz2
>
> The changes include:
>
> ~ make some test more robust
>
> ~ small internal optimizations
>
> ~ i386 pthread_cond_{,timed}wait code now uses exception based cleanup
>   handling; this removes about 10% of the code
>
> ~ fully implement pthread_getcpuclockid: it is now possible to get the
>   time for other threads
>
> ~ add appropriate _POSIX_* macros to announce CPU clocks on hammer and
>   ia64
>
>
> You need the glibc sources at least as of 2003-06-24T19:00:00-0700.
>
> - -- 
> - --------------.                        ,-.            444 Castro Street
> Ulrich Drepper \    ,-----------------'   \ Mountain View, CA 94041 USA
> Red Hat         `--' drepper at redhat.com `---------------------------
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.2.1 (GNU/Linux)
>
> iD8DBQE++TUK2ijCOnn/RHQRAl8bAJ9j40Dgn1vzXhodEPHbsKU0tzwJAwCdFqp+
> xertpPffCUbx56ft82bSG74=
> =RKaJ
> -----END PGP SIGNATURE-----
>
>
> -- 
> Phil-list mailing list
> Phil-list redhat com
> https://www.redhat.com/mailman/listinfo/phil-list
>




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]