[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Fwd: condvar wakeups]



In message <3EBC1FA6 9FA01306 austin ibm com> you write:
> @@ -5,7 +5,8 @@
>  #define FUTEX_WAIT (0)
>  #define FUTEX_WAKE (1)
>  #define FUTEX_FD (2)
> +#define FUTEX_REQUEUE (3)
>  
> -extern asmlinkage long sys_futex(u32 *uaddr, int op, int val, struct timespec *utime);
> +extern asmlinkage long sys_futex(u32 *uaddr, int op, int val, struct timespec *utime, u32 *uaddr2);

Hi Ingo,

	I think I prefer overloading the fourth arg rather than adding
a fifth: it doesn't seem really neccessary here.

> +	case FUTEX_REQUEUE:
> +		pos_in_page2 = uaddr2 % PAGE_SIZE;
> +
> +		/* Must be "naturally" aligned */
> +		if (pos_in_page2 % sizeof(u32))
> +			return -EINVAL;

Technically __alignof__(u32).  Sure, I'm nitpicking.

*Please* put your copyright at the top of futex.c: over half the code
is yours now (and it's all the tricky bits 8).

Thanks!
Rusty.
--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]