[PATCH] tst-cond16 fix - NPTL part
Jakub Jelinek
jakub at redhat.com
Fri May 21 08:02:46 UTC 2004
On Fri, May 21, 2004 at 09:58:53AM +0200, Thorsten Kukuk wrote:
> > Are you using a kernel without FUTEX_CMP_REQUEUE there as well?
>
> Yes, our build machines aren't updated yet.
>
> > Can you see with say strace if FUTEX_CMP_REQUEUE returns an error in all
> > cases that it is run and that it does the FUTEX_WAKE call afterwards?
>
> I will try it now.
BTW: there seems to be a forgotten ++cond->__data.__futex; in timedwait:
timeout:
/* Yep. Adjust the counters. */
++cond->__data.__wakeup_seq;
+ ++cond->__data.__futex;
/* The error value. */
result = ETIMEDOUT;
break;
but that should have no effect on tst-cond18 which doesn't use timedwait.
(i486 and x86_64 assembly seems to handle this right).
Jakub
More information about the Phil-list
mailing list