[Pki-devel] [PATCH] typesafety patches

[Ade Lee]

33 - ACK
34 - ACK
35 - ACK
36-  ACK
37 - ACK
38  
- In AuthAdminServlet.java , a suppress warnings annotation is placed
before addAuthMgrPlugin().  Can it be moved closer to the code causing
the warnings?
- Why has the return for the put() method in SourceConfigStore and
PropConfigStore (and the corresponding interfaces been changed from void
to string?  What is supposed to be returned here?

Ade

On Thu, 2011-12-22 at 15:22 -0500, Ade Lee wrote:
> 28 - ACK
> 29 - ACK
> 30 - ACK - but change the description.  This has nothing to do with
> TreeSet
> 31 - ACK
> 32 - For the most part - ACK.  RevokedCertImpl.java looks like it has
> been reformatted though -- which is obscuring the real changes in the
> file.  Please resubmit with just the relevant changes in that file.
> 
> Continuing with the rest ..
> 
> Ade
> 
> On Thu, 2011-12-22 at 13:08 -0500, Adam Young wrote:
> > These have been rebased on top of master  and might conflict with 
> > previously submitted patches.  These should all all be relatively 
> > independent,  but it is possible that some of the later patches require 
> > earlier patches in order to apply.  Please indicate the patch number in 
> > any ACK/NACK messages.
> > _______________________________________________
> > Pki-devel mailing list
> > Pki-devel at redhat.com
> > https://www.redhat.com/mailman/listinfo/pki-devel
> 
> 
> _______________________________________________
> Pki-devel mailing list
> Pki-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/pki-devel