[Pki-devel] [PATCH] 4 Replaced byte-to-char & char-to-byte converters.

[Adam Young]

On 12/13/2011 12:47 PM, Endi Sukma Dewata wrote:
> The byte-to-char and char-to-byte converters have been replaced
> with a set of charsets, each having its own decoders and encoders.
>
> Ticket #3
>
>
>
> _______________________________________________
> Pki-devel mailing list
> Pki-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/pki-devel



Nicely done,  I've given it a visual quick look over.  A minor nit is 
that you shouldn't use

import    java.util.*;  but instead list the elements individually.

I would like to see this split into two patches,  one that moves the 
files into the proper package and a second that changes to the 
nondeprecated API.  If you have it that way in your Git  repo, please 
post it,  so I can see what is changed in the moved files.  If not,  it 
isn't that hard to set up to do the diff by hand.





-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/pki-devel/attachments/20111213/b8dfbfc6/attachment.htm>