[Pki-devel] [PATCH] 0018-PKISilent-in-single-tre

[Matthew Harmsen]

ACK.

As we discussed, in 
"pki/base/silent/src/com/netscape/pkisilent/common/TestClient.java", if 
possible please make the "public String PWD;" into "protected String 
PWD;" as it refers to a "password" in this context; if not possible to 
be made into a "protected" class, perhaps create a public method to 
assign data to this private variable.

On 11/15/11 14:57, Adam Young wrote:
> IPA assumes pkisilent is a Perl executable and calls via 
> /usr/bin/perl.  Also,  the shell version was not honoring how IPA 
> needs to wrap the arguments to PKI Silent
>
>
> On 11/15/2011 05:00 PM, Adam Young wrote:
>> On 11/14/2011 03:44 PM, Adam Young wrote:
>>> Tested as far as calling a bunch of the Subordinate classes:  
>>> ConfigureCA,  ConfigureDRM.  In general,  this patch doesn't change 
>>> the behavior of anything,  just the structure
>>>
>>> To simply development,  and because Perl was really unnecessary for 
>>> this,  the pkisilent wrapper has been redone in Bash.  If you wish 
>>> to test out what this actually does, set -x  on the bash line and 
>>> run it.
>>>
>>>
>>> _______________________________________________
>>> Pki-devel mailing list
>>> Pki-devel at redhat.com  <mailto:Pki-devel at redhat.com>
>>> https://www.redhat.com/mailman/listinfo/pki-devel
>> Self NACK on this one.  It does not properly handle the parameters 
>> with spaces in them,  most notable "Directory Manager"
>>
>>
>> _______________________________________________
>> Pki-devel mailing list
>> Pki-devel at redhat.com  <mailto:Pki-devel at redhat.com>
>> https://www.redhat.com/mailman/listinfo/pki-devel
>
>
>
> _______________________________________________
> Pki-devel mailing list
> Pki-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/pki-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/pki-devel/attachments/20111116/57b95096/attachment.htm>