[Pki-devel] [PATCH] 17 Removed unused variables (part 1).

[Ade Lee]

Some additional comments:

1. You can eliminate the call for the variable keyAlgorithm in
SizePanel.java

2.  Rather then removing the currently unused error message - you should
change the log statement to use it in JobScheduler.java.

In other words, change statements like:
 log(ILogger.LL_FAILURE, CMS.getLogMessage("CMSCORE_JOBS_INIT_ERROR", e.toString()));
to :
 log(ILogger.LL_FAILURE, CMS.getLogMessage("CMSCORE_JOBS_INIT_ERROR", errMsg));

The same comment applies to PublisherProcessor.java and UGSubsystem.java

3. Remove the unused exceptions in LdapAnonConnFactory and LdapBoundConnFactory.

Otherwise the rest looks ok.

You should confirm that it all passes a smoke test - which consists of:

1. Install and configure a CA and KRA.
2. Confirm issuance of some certs, archival of an encryption keys, revocation of a cert and generation of CRL
3. Run console and confirm that all the fields look ok.

Ade

On Tue, 2012-02-14 at 16:17 -0600, Endi Sukma Dewata wrote:
> This patch brings down the warnings from 2917 to 2408.
> 
> Ticket #2
> 
> http://fedorapeople.org/gitweb?p=edewata/public_git/pki.git;a=commitdiff;h=f7c912e06dd2c6722d30d9dbcf31d5ab5db0a7be
> 
> _______________________________________________
> Pki-devel mailing list
> Pki-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/pki-devel