[Pki-devel] [PATCH] 17 Removed unused variables (part 1).

[Ade Lee]

ACK

On Mon, 2012-02-20 at 09:13 -0600, Endi Sukma Dewata wrote:
> New patch attached. It can be viewed here:
> 
> http://fedorapeople.org/gitweb?p=edewata/public_git/pki.git;a=commitdiff;h=6113d7d2f9f10a0a6c1ae02d53d2f8a54c17b173
> 
> On 2/16/2012 9:56 PM, Ade Lee wrote:
> > 1. You can eliminate the call for the variable keyAlgorithm in
> > SizePanel.java
> 
> Fixed.
> 
> > 2.  Rather then removing the currently unused error message - you should
> > change the log statement to use it in JobScheduler.java.
> >
> > In other words, change statements like:
> >   log(ILogger.LL_FAILURE, CMS.getLogMessage("CMSCORE_JOBS_INIT_ERROR", e.toString()));
> > to :
> >   log(ILogger.LL_FAILURE, CMS.getLogMessage("CMSCORE_JOBS_INIT_ERROR", errMsg));
> >
> > The same comment applies to PublisherProcessor.java and UGSubsystem.java
> 
> As discussed, the static messages are duplicates of the messages in the 
> resource bundle, so we don't need to include it again. The static 
> messages have been removed.
> 
> > 3. Remove the unused exceptions in LdapAnonConnFactory and LdapBoundConnFactory.
> 
> Fixed.
> 
> > Otherwise the rest looks ok.
> >
> > You should confirm that it all passes a smoke test - which consists of:
> >
> > 1. Install and configure a CA and KRA.
> > 2. Confirm issuance of some certs, archival of an encryption keys, revocation of a cert and generation of CRL
> > 3. Run console and confirm that all the fields look ok.
> 
> These are confirmed. BTW, I think we need to standardize the smoke test. 
> We can discuss this in the next meeting.
>