[Pki-devel] [PATCH] 11 Added generics (part 1).

[John Magne]

Looked over this:

Much of it is converting raw collections to generic ones with types.
Most of this is straightforward. I just had a few questions since it looks like
this patch drills down to the extension level which is pretty low.



Questions:

The following construct below originally looked odd, but upon further review online,
it appears that this is a generic method where the "<V>" at the front denotes a type.
This is legitimate but it looks like this getExtDataInHashtable is used extensively, it 
would be nice to know if we've done some simple testing to see if this works as expected.


-    public Hashtable getExtDataInHashtable(String key);
+    public <V> Hashtable<String, V> getExtDataInHashtable(String key);

Somehow in rifling through 10,000 lines I picked out this below:


CertificatePoliciesExtDefault.java

-            Vector infos = null;
+            Vector<CertificatePolicyInfo> infos;

Looks like we didn't set info to null here:


Otherwise I think that it comes down to how much simple testing have we done to make 
sure extensions still work as expected? I noticed the unit testing and that's great.



----- Original Message -----
From: "Endi Sukma Dewata" <edewata at redhat.com>
To: pki-devel at redhat.com
Sent: Friday, January 13, 2012 7:53:22 AM
Subject: [Pki-devel] [PATCH] 11 Added generics (part 1).

This patch is based on Adam's patch. It brings down the warnings
from 6137 to 4656.

Ticket #2

http://fedorapeople.org/gitweb?p=edewata/public_git/pki.git;a=commitdiff;h=0cf280a1c37d89ae4501a766f38275be0fcb7408

-- 
Endi S. Dewata

_______________________________________________
Pki-devel mailing list
Pki-devel at redhat.com
https://www.redhat.com/mailman/listinfo/pki-devel