[Pki-devel] [PATCH] 18-3 , 19-3 -- Minor Fixes for 18-2 , 19-2

[Abhishek Koneru]

Please review the patches 18-3 and 19-3 , which have the fixes for
review comments on 18-2 and 19-2.

Regards,
Abhishek

On Mon, 2012-07-02 at 11:58 -0500, Endi Sukma Dewata wrote:
> On 7/2/2012 10:35 AM, Abhishek Koneru wrote:
> > Please review the patches 18-2 and 19-2 with fixes for review comments
> > on Patches 18 and 19.
> 
> Some issues in patch #18-2:
> 
> 1. In CrossCertPairSubsystem.java:104-107 the new code looks like this:
> 
>    mCa = (ICertificateAuthority) CMS.getSubsystem("ca");
>    synchronized (this) {
>        mPublisherProcessor = mCa.getPublisherProcessor();
>    }
> 
> The mCa is accessed twice, one without lock and the other with lock. I 
> suppose Coverity will complain about it. The mCa is already synchronized 
> in shutdown(), so we should synchronize mCa everywhere else too.
> 
>    synchronized (this) {
>        mCa = (ICertificateAuthority) CMS.getSubsystem("ca");
>        mPublisherProcessor = mCa.getPublisherProcessor();
>    }
> 
> 2. Formatting issue in DBVirtualList.java:311-320.
> 
> For patch #19-2, let's return the "fos" variable declarations into their 
> original locations. These variables are handling different files and 
> there is nothing shared among them, so there is no need to have a common 
> "fos" variable. By moving the declarations back, we minimize the scope 
> of each variable, so it's easier to read the code or if we want to break 
> the method into smaller methods.
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: pki-akoneru-0018-3-Minor-Fixes-in-18-2.patch
Type: text/x-patch
Size: 2550 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/pki-devel/attachments/20120702/db2c83df/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pki-akoneru-0019-3-Minor-Fix-to-19-2.patch
Type: text/x-patch
Size: 2955 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/pki-devel/attachments/20120702/db2c83df/attachment-0001.bin>