[Pki-devel] [PATCH] PKI Deployment Framework PKI TRAC issues (07/25/2012)

[Matthew Harmsen]

NOTE:  This version of the patch applies the fixes previously requested:

    Comments:
    1. As noted, please open trac ticket to remove custom args from the
    command line from pkispawn, and add -i instance mandatory parameter to
    pkidestroy.

    2. In pkihelper, you add logic that separates out the case of the
    subordinate CA because subordinate is not defined for any subsystem
    other than a CA.  You could leave it in the same conditional, and
    simplify the conditional to be: if (clone) or (!ca) or (subordinate):

    3. Please shorten the name of
    util.namespace.pki_instance_name_collision_detection_avoidance()

    You can make those changes and check in without re-review.  As long as
    you test of course to confirm you have not broken anything.

    Ade


This patch documents continued implementation of the PKI Deployment 
Framework based upon the revised filesystem layout documented here:

  * http://pki.fedoraproject.org/wiki/PKI_Instance_Deployment#CA_.2F_KRA_.2F_OCSP_.2F_RA_.2F_TKS_.2F_TPS

This patch addresses the following issues:

  * PKI TRAC Ticket #244 - Non-user-friendly message when deleting
    non-existent subsystem with pkidestroy
  * PKI TRAC Ticket #246 - Incorrect parameter names in pkispawn
    configuration
  * PKI TRAC Ticket #248 - pki_ds_database should not be a DN
  * PKI TRAC Ticket #249 - pki_ds_base_dn causing pkispawn failure
  * PKI TRAC Ticket #250 - Creating/removing custom instances should not
    require http/ajp ports
  * PKI TRAC Ticket #251 - Instance name may conflict with other files
  * PKI TRAC Ticket #253 - Fix pki-destroy removal of
    '/var/log/pki/{pki_instance_id}' directory . . .
  * PKI TRAC Ticket #254 - Dogtag 10: Fix spec file to build
    successfully via mock on Fedora 17 . . .
  * PKI TRAC Ticket #255 - Missing resteasy-atom-provider.jar
  * PKI TRAC Ticket #260 - Dogtag 10: Change the layout of
    'pki_instance_id' . . .

*WARNING:  As this patch does fundamentally change instance names from 
"[pki_admin_domain_name-]pki_instance_name" to 
"pki_instance_name[.pki_admin_domain_name]", users of this patch must 
FIRST remove all old PKI instances.*

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/pki-devel/attachments/20120725/88472949/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-PKI-Deployment-Scriptlets-PKI-TRAC-issues.patch
Type: text/x-patch
Size: 49539 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/pki-devel/attachments/20120725/88472949/attachment.bin>