[Pki-devel] [PATCH] 26-3 Fix for review comment given for [PATCH] 26-2

[Abhishek Koneru]

Please review the fix for the comment given for patch 26-2

--Abhishek Koneru
On Thu, 2012-07-26 at 18:39 -0500, Endi Sukma Dewata wrote:
> On 7/26/2012 3:33 PM, Abhishek Koneru wrote:
> > Please find attached the fixes for comments given for Patch26.
> 
> I've tested the patch. It works, but there's one issue:
> 
> 8. The review command should store the output into a file so that the 
> agent can review and make changes then send it back to the server to 
> approve it. So the command would look something like this:
> 
>    # pki cert-request-review 10 --output <file>
>    ---------------------------------
>    Downloaded certificate request 10
>    ---------------------------------
> 
>    ... <agent reviews & makes changes> ...
> 
>    # pki cert-request-approve <file>
>    -------------------------------
>    Approved certificate request 10
>    -------------------------------
> 
> There is another issue, if you try to approve a request that's already 
> been approved it will generate an exception (the message is not nicely 
> displayed). This is probably due to a bug in RESTEasy where it doesn't 
> handle exception very well on methods that returns void. I think it will 
> be fixed when we upgrade to the latest RESTEasy version. See this 
> ticket: https://fedorahosted.org/pki/ticket/194
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: pki-akoneru-0026-3-Cert-CLI-cert-request-review-and-cert-request-approv.patch
Type: text/x-patch
Size: 16743 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/pki-devel/attachments/20120727/678287d4/attachment.bin>