[Pki-devel] [PATCH] 77 Updated util and common build scripts.

[Endi Sukma Dewata]

New patch attached. Please apply in this order: 80, 81, 77-1, 78, 79.

On 7/18/2012 12:14 AM, Ade Lee wrote:
> This is really cool, but there are some issues:
>
> 1. The contents in pki-cmsbundle.jar are not the same as before.  This
> is probably a cut-and-paste error.

Fixed in the revised patch.

> 2. pki-cmscore.jar now includes the realm classes (which it did not do
> before).  So these classes are now delivered in pki_jndi_realm.jar and
> pki-cmscore.jar.

Fixed using exclusion.

> 3. The build succeeds when specifying --without-javadoc, and fails when
> building javadoc as well.

Fixed using the new javadoc function.

> As a sanity check, please compare the contents of the jars before and
> after the patch to ensure that they are the same.

I have verified this using a script. The script is available at:
http://fedorapeople.org/gitweb?p=edewata/public_git/pki-dev.git

1. Copy the old jar files before the patch (excluding the symlinks) from 
/usr/share/java/pki into a separate folder.
2. Apply the patch, rebuild and reinstall the rpms.
3. Run this command:

    <pki-dev>/scripts/compare-jars.sh \
        <folder containing the old jar files> \
        /usr/share/java/pki

If the content differs it should appear in the output.

-- 
Endi S. Dewata
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pki-edewata-0077-1-Updated-util-and-common-build-scripts.patch
Type: text/x-patch
Size: 92153 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/pki-devel/attachments/20120718/9a72e876/attachment.bin>