[Pki-devel] [PATCH] 41 - Merge most DAO objects into ResourceService files

[Endi Sukma Dewata]

On 7/24/2012 1:48 PM, Ade Lee wrote:
> We decided we no longer need the DAO level.  I have merged the logic in
> those files into the ResourceService files.
>
> The DAO objects for Requests still seem to be useful though - mainly
> because requests have a lot in common for keys and certs - so we may or
> may not remove them.  Either way, we'll deal with them in a separate
> patch.

A few minor issues:

1. There's an empty line with just ";" in CertResourceService.java:455. 
It should be removed.

2. In KeyResourceService.java:65 the super() is redundant.

3. In KeyResourceService.java:270,283 it's no longer necessary to pass 
uriInfo via parameter.

4. In ProfileResourceService.java:113 please remove the auto-generated 
comment.

5. In ProfileResourceService.java:64,179 it's no longer necessary to 
pass uriInfo via parameter.

Other than that it's ACKed. We probably can rename the remaining DAO to 
Processor. So it will be like RequestProcessor, CertRequestProcessor and 
KeyRequestProcessor.

-- 
Endi S. Dewata