[Pki-devel] [PATCH] 23 Fixed IAttrSet.getElements() implementations.

[Ade Lee]

Endi, 

I was at first a little leery of the changes in getElement() in
AuthCredentials.java and EmailResolverKeys.java.  While the change seems
to make sense from looking at the class, it was not clear why the
methods had been working this far with no issues.  But, it seems to me
-- and you should confirm this -- that these methods are currently
unused and therefore we can change them with no problems.

Please confirm that they are not called - not only in Java but also
Javascript code.

There are a couple of files in the patch where the only change appears
to be adding a line at the end of the file.  Is that intentional and/or
needed?  (LdapPredicateParser, PolicyPredicateParser).

In Main.java in 71ToText, there appears to be an error - with a
duplicate assignment taking place.

Ade

On Fri, 2012-02-24 at 14:40 -0600, Endi Sukma Dewata wrote:
> This patch fixes incorrect implementation of getElement() in
> some subclasses of IAttrSet. The method is supposed return the
> attribute names as an enumeration of strings.
> 
> Ticket #42
> 
> _______________________________________________
> Pki-devel mailing list
> Pki-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/pki-devel