[Pki-devel] [PATCH] 24 Refactored NameValuePairs.

Endi Sukma Dewata edewata at redhat.com
Mon Mar 12 17:45:54 UTC 2012


On 3/8/2012 9:14 AM, Ade Lee wrote:
> Whew! That was a long review .. lots of files changed.
>
> I was starting to see a bunch of formatting errors in the console code,
> only to realize that the console code somehow missed reformatting.  So,
> after the checkins are done, its worth doing a reformat of the console
> code.  I will run that and submit as a separate patch.
>
> Please make sure you check things out on the console to confirm they
> look OK.  Is so, ACK.

Everything looks OK in console. Pushed to master. Thanks.


> On Mon, 2012-02-27 at 12:25 -0600, Endi Sukma Dewata wrote:
>> The NameValuePairs class has been modified to extend the Linked-
>> HashMap which preserves the order of elements as in the original
>> code. Some methods are renamed to match Java Map interface. The
>> NameValuePair class is no longer needed and has been removed.
>>
>> Ticket #78
>>
>> http://fedorapeople.org/gitweb?p=edewata/public_git/pki.git;a=commitdiff;h=e7c603e871bca4345f2da73e39de6ffd786ffc13
>>
>> Passed smoke test.


-- 
Endi S. Dewata




More information about the Pki-devel mailing list