[Pki-devel] [PATCH] 23 Fixed IAttrSet.getElements() implementations.

[Endi Sukma Dewata]

New patch attached.

On 3/7/2012 10:35 PM, Ade Lee wrote:
> I was at first a little leery of the changes in getElement() in
> AuthCredentials.java and EmailResolverKeys.java.  While the change seems
> to make sense from looking at the class, it was not clear why the
> methods had been working this far with no issues.  But, it seems to me
> -- and you should confirm this -- that these methods are currently
> unused and therefore we can change them with no problems.
>
> Please confirm that they are not called - not only in Java but also
> Javascript code.

Yes, I couldn't find any references to the getElements() method that 
uses the above classes.

> There are a couple of files in the patch where the only change appears
> to be adding a line at the end of the file.  Is that intentional and/or
> needed?  (LdapPredicateParser, PolicyPredicateParser).

Actually the patch removes unused AttributeSet class from those files. 
I've revised the patch to remove unused imports too.

> In Main.java in 71ToText, there appears to be an error - with a
> duplicate assignment taking place.

This is fixed now.

-- 
Endi S. Dewata
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dogtag-edewata-0023-1-Fixed-IAttrSet.getElements-implementations.patch
Type: text/x-patch
Size: 18606 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/pki-devel/attachments/20120312/47570c8d/attachment.bin>