[Pki-devel] [PATCH] 80 default instances

[Ade Lee]

On Fri, 2012-11-02 at 17:09 -0500, Endi Sukma Dewata wrote:
> On 11/2/2012 2:24 PM, Ade Lee wrote:
> > Set paths for default instance
> >
> >      With this patch, it will be possible to install a default instance
> >      simply by adding the passwords in the pkideployment.cfg.  This file
> >      can then be used without additional alteration to add subsystems to the
> >      same instance, by re-running pkispawn against the config file.
> >
> >      The patch makes sure that cert nicknames, database and baseDN , admin users
> >      and client db are unique per subsystem.  An option is added to reuse the
> >      existing server cert generated by the first subsystem and copy the
> >      required data to all subsystems.
> >
> >      Ticket 379, 385
> >
> > Please review.
> > Ade
> 
> As mentioned on IRC, I have some comments:
> 
> 1. The read_simple_configuration_file seems to ignore the sections in 
> the deployment config file. Would this become a problem? There are 
> parameters that exist in multiple sections, so whichever defined later 
> may overwrite the earlier.

Does not apply. The config file read is CS.cfg.
> 
> 2. The pkidestroy still requires -i <instance> parameter. To be 
> consistent it probably should be made optional and default to pki-tomcat.
> 
This will be accounted for in the patch for default instances part 2.

Acked by Endi.  Pushed to master.