[Pki-devel] [PATCH] 149 Merged theme files.

Ade Lee alee at redhat.com
Tue Nov 6 06:20:11 UTC 2012


Oh, incidentally the following patches introduce some white space errors
- 155, 156, 158, 559

On Tue, 2012-11-06 at 01:18 -0500, Ade Lee wrote:
> Comments here on 149 and 150-168.
> 
> Nicely done.  I do think that it makes sense to combine all the image
> and css files in one location.  This helps in ensuring a consistent look
> and feel across the servers.  
> 
> What this means, of course, is that all common image files must be
> exactly the same -- that is certificate.jpg must be the same in all of
> the ca-ui, ra-ui, tps-ui etc. as any one of them could be overwritten as
> more subsystems are added to an instance.   I checked briefly, but I
> assume you confirmed that this was in fact the case.
> 
> In which case, it seems that in order to prevent files from getting out
> of sync - we should in fact deliver all the image files out of common-ui
> - and remove them from the ca-ui, kra-ui, tps-ui etc.  So the
> <subsystem>-ui files would just contain template files (and in the case
> of the tps, some extra css and gif files for the esc interface)
> 
> We would then need to require common-ui for the tps-ui and ra-ui, and we
> would not need the code to copy image files from the <subsystem>-ui
> directories.
> 
> Moreover, the image files that are not referenced at all in the template
> and html files are likely only used (if at all) in the CS 8.x package.
> They do not apply to the dogtag UI and should be removed.
>   
> Ade
> 
> 
> On Mon, 2012-11-05 at 13:49 -0600, Endi Sukma Dewata wrote:
> > Currently the theme files are copied into each subsystem during
> > deployment creating duplicates. To reduce the problem the files
> > should be combined into a common folder /pki.
> > 
> > The process will be done over several patches. Initially this patch
> > will copy the images and CSS files into /pki/images and /pki/css.
> > Subsequent patches will update references to these files to the new
> > location. When it's done, the files no longer need to be copied
> > into each subsystem.
> > 
> > Ticket #328
> > 
> > _______________________________________________
> > Pki-devel mailing list
> > Pki-devel at redhat.com
> > https://www.redhat.com/mailman/listinfo/pki-devel
> 
> 
> _______________________________________________
> Pki-devel mailing list
> Pki-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/pki-devel





More information about the Pki-devel mailing list