[Pki-devel] [PATCH] 48 Show some more information after installation

Endi Sukma Dewata edewata at redhat.com
Mon Apr 8 18:25:42 UTC 2013


On 4/5/2013 9:59 AM, Abhishek Koneru wrote:
> Some more changes added to the patch. Please ignore the previous post.
> Please review the attached patch.

Some comments:

1. There's a typo:

   PKI_CHECK_STATUS_MESSAGE = "COmmand...

2. Please also show the following information:
- Admin username
- Location of client database
- Client certificate nickname

This way the admin knows the parameters needed to use the CLI.

3. Could we move these messages before 'Installation complete'? If the 
messages are long it will be more difficult to see the result of the 
installation.

4. Some trailing whitespaces.

-- 
Endi S. Dewata




More information about the Pki-devel mailing list