[Pki-devel] [PATCH] 48-2 Fixes for [Patch] 48 Show some more information after installation

[Abhishek Koneru]

Please review the patch with fixes for the review comments for patch 48

On Mon, 2013-04-08 at 13:25 -0500, Endi Sukma Dewata wrote:
> On 4/5/2013 9:59 AM, Abhishek Koneru wrote:
> > Some more changes added to the patch. Please ignore the previous post.
> > Please review the attached patch.
> 
> Some comments:
> 
> 1. There's a typo:
> 
>    PKI_CHECK_STATUS_MESSAGE = "COmmand...
> 
> 2. Please also show the following information:
> - Admin username
> - Location of client database
> - Client certificate nickname
> 
Added these details.
> This way the admin knows the parameters needed to use the CLI.
> 
> 3. Could we move these messages before 'Installation complete'? If the 
> messages are long it will be more difficult to see the result of the 
> installation.

Information is printed above the 'Installation complete' message.
> 
> 4. Some trailing whitespaces.
Fixed.
> 

--Abhishek

-------------- next part --------------
A non-text attachment was scrubbed...
Name: pki-akoneru-0048-2-Show-some-more-information-after-installing-a-subsys.patch
Type: text/x-patch
Size: 4687 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/pki-devel/attachments/20130409/514a90ac/attachment.bin>