[Pki-devel] Request for review: Bug 928680 - Minor additions to pkisilent (ECC)

[Ade Lee]

Endi brought up an interesting question ..

In this code, you do a string comparison to find the CA cert.
 
+                if  (ca_certs[i].getSubjectDN().toString().equals(
+                    cert.getIssuerDN().toString())) {

Is a string comparison valid?  For example, if one uses c=US and the
other uses C=US, then the string comparison might fail.  Shouldn't some
DN comparison operation be done instead?

Ade

On Thu, 2013-04-11 at 11:35 -0400, Ade Lee wrote:
> ACK
> 
> On Wed, 2013-04-10 at 21:05 -0700, Christina Fu wrote:
> > Please review the following patch for 
> > https://bugzilla.redhat.com/show_bug.cgi?id=928680
> > 
> > https://bugzilla.redhat.com/attachment.cgi?id=733986&action=diff&context=patch&collapsed=&headers=1&format=raw
> > 
> > Please note that the 1st reported issue regarding trust bits was 
> > pre-existing with RSA, so it is not specific to ECC.
> > 
> > thanks,
> > Christina
> > 
> > _______________________________________________
> > Pki-devel mailing list
> > Pki-devel at redhat.com
> > https://www.redhat.com/mailman/listinfo/pki-devel
> 
> 
> _______________________________________________
> Pki-devel mailing list
> Pki-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/pki-devel