[Pki-devel] [PATCH] 56-2 Fixes fo review comments on patch - 56 Add error logs when executing pkispawn Ticket#592

[Ade Lee]

ACK.

I have pushed this patch with a couple of small modifications.

In pkispawn, in the exception code, you print that the "Installation
failed" and then exit(0).  It should be exit(1).

I similarly added a message that the installation failed to the
conditional that follows the exception code.

On Fri, 2013-04-26 at 00:12 -0400, Abhishek Koneru wrote:
> Please review the attached patch which prints the error message from the
> configuration servlet.
> 
> For Example: 
>   I tested by installing a CA and then a clone CA, but the clone's base
> DN does not match with the master's. The following output is printed.
> 
> Actual error seen in the text section of the HTTPResponse object
> received in the HTTPError object:
> 
> <?xml version="1.0" encoding="UTF-8"
> standalone="yes"?><PKIException><ClassName>com.netscape.certsrv.base.BadRequestException</ClassName><Code>400</Code><Message>Master and clone should have the same base DN</Message><Attributes/></PKIException>
> 
> Error message printed in the debug log (added in this patch): 
> Exception from Java Configuration Servlet: Master and clone should have
> the same base DN
> 
> --Abhishek
> On Thu, 2013-04-25 at 11:04 -0400, Ade Lee wrote:
> > All of the above is good.  What am really interested in though, is
> > whether error messages that are sent back with exceptions from the
> > config servlet are reported.  At last look, it looked like these were
> > not reported.
> > 
> > You can test this by sending in some bad data -- say setting up a clone
> > where the base DN does not match the master, or sending in any of the
> > various ways to fail the validation function in
> > SystemConfigService.java.
> > 
> > 
> > On Thu, 2013-04-25 at 09:47 -0400, Abhishek Koneru wrote:
> > > Please review the patch which add the stack trace and message
> > > information to the debug logs, if an error occurs while executing
> > > pkispawn. #592
> > > 
> > > --Abhishek
> > > 
> > > 
> > > _______________________________________________
> > > Pki-devel mailing list
> > > Pki-devel at redhat.com
> > > https://www.redhat.com/mailman/listinfo/pki-devel
> > 
> > 
> 
> _______________________________________________
> Pki-devel mailing list
> Pki-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/pki-devel