[Pki-devel] [PATCH] 208 Additional output attributes for cert-find.

Endi Sukma Dewata edewata at redhat.com
Thu Feb 7 22:16:29 UTC 2013


On 2/7/2013 11:10 AM, Endi Sukma Dewata wrote:
> On 2/6/2013 11:05 PM, Ade Lee wrote:
>> 1. In CertDataInfo.java,  getKeyLength() needs a @XmlElement annotation.
>
> This will be fixed before push.
>
>> 2. The code setting the key in CertService.java in createCertDataInfo()
>> is specific to RSA keys.  What about ECC keys?
>
> Christina, the code in ListCerts.fillX509RecordIntoArg() (which the
> patch was adapted from) doesn't seem to handle ECC keys, is it correct?
> Do we need to add a support for ECC keys here?

As discussed over IRC, this will be added in a separate ticket.

ACKed by Ade. Pushed the revised patch to master.

-- 
Endi S. Dewata




More information about the Pki-devel mailing list