[Pki-devel] Request for review: ECC support for pkisilent (CA, subCA, DRM, TKS, TPS, OCSP)

[Ade Lee]

Comments:

In general, the code changes look fine.  Just a couple of nitpicks ..

1. The variable save_p12 should be a boolean rather than a string.

2. In ComCrypto.java, you define setTokenName().  What about
getTokenName()?

3. In ComCrypto.java,on line 448, you cast token to (PK11Token) and on
450, there is no cast.  Why the discrepancy?  Is the cast needed?

4. The exception handling in ComCrypto.java for lines 448/450 is pretty
wonky.  It seems like token could return null.  Could we improve the
exception handling in this case?

Ade

On Tue, 2The 013-02-19 at 11:26 -0800, Christina Fu wrote:
> This is a request for code review for the following feature bug:
> Bug 810967 - [RFE] ECC support for pkisilent 
> 
> the code changes can be found here:
> https://bugzilla.redhat.com/attachment.cgi?id=699587&action=diff&context=patch&collapsed=&headers=1&format=raw
> 
> The 5 new templates and one readme instruction file can be found the
> the bug attachment.
> 
> thanks!
> Christina
> 
> 
> _______________________________________________
> Pki-devel mailing list
> Pki-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/pki-devel