[Pki-devel] [PATCH] 66, 67 Fixing warnings reported by pylint in Dogtag 10 python code.
Abhishek Koneru
akoneru at redhat.com
Wed Jul 10 18:14:28 UTC 2013
Fixed the trailing whitespace errors and enabled the pylint check for
W0212 - Accessing protected variables on discussing with Ade.
The fixed patches are pushed to master.
--Abhishek
On Tue, 2013-07-09 at 14:19 -0400, Abhishek Koneru wrote:
> Sorry for the spam. The comments mentioned were from the report before.
> --Abhishek
> On Tue, 2013-07-09 at 12:27 -0400, Abhishek Koneru wrote:
> > Please review the patches which address the following warnings reported
> > by pylint.
> >
> > +-----------+------------+
> > |message id |occurrences |
> > +===========+============+
> > |W0403 |84 |Relative import error (Need to investigate.)
> > +-----------+------------+
> > |W1401 |34 |Anomalous backslash in string: ‘%s’. (All
> > occurences in regex patterns)
> > +-----------+------------+
> > |W0613 |12 |Unused argument %r (This is mainly due to the
> > keyboard interrupt handler - in every script )
> > +-----------+------------+
> > |W0221 |6 |Arguments number differs from %s method (These
> > cases are basic function overriding, did not find a specific reason as
> > to why this is causing a warning)
> > +-----------+------------+
> > |W0621 |4 |Redefining name %r from outer scope (All cases
> > related to interrupt handler code in pki* scripts)
> > +-----------+------------+
> > |W0212 |4 |Access to a protected member %s of a client
> > class (Found in pkiparser.py in compose_slots_dict function. This is the
> > only way for retrieving all the key-value pairs in a section )
> > +-----------+------------+ (without any entries from the default
> > sections in the dict.)
> > |W0612 |1 |Unused variable %r (A starightforward fix)
> > +-----------+------------+
> >
> >
> > Issues remaining to be fixed -
> >
> > Messages
> > --------
> >
> > +-----------+------------+
> > |message id |occurrences |
> > +===========+============+
> > |W0201 |25 |Attribute %r defined outside __init__
> > +-----------+------------+
> > |E0202 |1 |An attribute affected in %s line %s hide this
> > method. E0202: 15,4:CustomTypeEncoder.default: An attribute affected in
> > json.encoder line 157 hide this method (in encoder.py)
> > +-----------+------------+
> >
> > --Abhishek
> > _______________________________________________
> > Pki-devel mailing list
> > Pki-devel at redhat.com
> > https://www.redhat.com/mailman/listinfo/pki-devel
>
>
> _______________________________________________
> Pki-devel mailing list
> Pki-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/pki-devel
More information about the Pki-devel
mailing list