[Pki-devel] [PATCH] 69 Last set of fixes for warnings and errors reported by pylint for Dogtag10.1 branch

[Abhishek Koneru]

Please review the patch with fixes for remaining two issues reported by
pylint.

1. Attribute defined outside init.
2. Instance attribute hiding a class method (Ignored as the problem is
in json.encoder.JSONEncoder).

Also attached the final report.

--Abhishek
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pki-akoneru-0069-Fixes-for-issues-reported-by-pylint.patch
Type: text/x-patch
Size: 4955 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/pki-devel/attachments/20130717/7d49380e/attachment.bin>
-------------- next part --------------


Report
======
8030 statements analysed.

External dependencies
---------------------
::

    ldap (pki.deployment.pkiparser,pkispawn)
    pki (pki-upgrade,pki.upgrade,pki.deployment.pkiparser,pki.server,pki/server/,pki-server-upgrade,pki.server.upgrade)
      \-account (pki.deployment.pkiparser,pki.deployment.pkihelper)
      \-client (pki.deployment.pkiparser,pki.deployment.pkihelper)
      \-deployment 
      | \-pkiconfig (pki.deployment.pkihelper,pki.deployment.webapp_deployment,pki.deployment.pkimanifest,pki.deployment.pkiparser,pkidestroy,pki.deployment.initialization,pki.deployment.selinux_setup,pki.deployment.instance_layout,pki.deployment.security_databases,pkispawn,pki.deployment.infrastructure_layout,pki.deployment.finalization,pki.deployment.configuration,pki.deployment.slot_substitution,pki.deployment.subsystem_layout)
      | | \-pki_selinux_config_ports (pki.deployment.pkihelper,pki.deployment.selinux_setup)
      | \-pkihelper (pkidestroy,pkispawn)
      | \-pkilogging (pki.deployment.pkiparser,pkidestroy,pkispawn)
      | \-pkimanifest (pki.deployment.pkihelper,pki.deployment.finalization)
      | \-pkimessages (pki.deployment.pkihelper,pki.deployment.webapp_deployment,pki.deployment.pkimanifest,pki.deployment.pkiparser,pkidestroy,pki.deployment.initialization,pki.deployment.selinux_setup,pki.deployment.instance_layout,pki.deployment.security_databases,pkispawn,pki.deployment.infrastructure_layout,pki.deployment.finalization,pki.deployment.configuration,pki.deployment.slot_substitution,pki.deployment.subsystem_layout)
      | \-pkiparser 
      | | \-PKIConfigParser (pki.deployment.pkihelper,pkidestroy,pkispawn)
      | \-pkiscriptlet (pki.deployment.webapp_deployment,pki.deployment.finalization,pki.deployment.initialization,pki.deployment.selinux_setup,pki.deployment.instance_layout,pki.deployment.security_databases,pki.deployment.infrastructure_layout,pki.deployment.configuration,pki.deployment.slot_substitution,pki.deployment.subsystem_layout)
      \-encoder (pki.system,pki.deployment.configuration)
      \-server (pki.server.upgrade)
      | \-upgrade (pki-server-upgrade)
      \-system (pki.deployment.pkiparser,pki.deployment.pkihelper,pki.deployment.configuration)
      \-upgrade (pki.deployment.pkiparser,pki-server-upgrade,pki.server.upgrade,pki-upgrade)
      | \-verbose (pki.server.upgrade)
      \-util (pki.upgrade)
    requests (pki.deployment.pkiparser,pki.client,pkispawn,pki.deployment.pkihelper)
    selinux (pki.deployment.pkihelper,pki.deployment.selinux_setup)
    seobject (pki.deployment.pkihelper,pki.deployment.selinux_setup)



Statistics by type
------------------

+---------+-------+-----------+-----------+------------+---------+
|type     |number |old number |difference |%documented |%badname |
+=========+=======+===========+===========+============+=========+
|module   |51     |51         |=          |NC          |NC       |
+---------+-------+-----------+-----------+------------+---------+
|class    |86     |86         |=          |NC          |NC       |
+---------+-------+-----------+-----------+------------+---------+
|method   |407    |407        |=          |NC          |NC       |
+---------+-------+-----------+-----------+------------+---------+
|function |32     |32         |=          |NC          |NC       |
+---------+-------+-----------+-----------+------------+---------+



Messages by category
--------------------

+-----------+-------+---------+-----------+
|type       |number |previous |difference |
+===========+=======+=========+===========+
|convention |0      |0        |=          |
+-----------+-------+---------+-----------+
|refactor   |0      |0        |=          |
+-----------+-------+---------+-----------+
|warning    |0      |0        |=          |
+-----------+-------+---------+-----------+
|error      |0      |1        |-1.00      |
+-----------+-------+---------+-----------+



Global evaluation
-----------------
Your code has been rated at 10.00/10 (previous run: 9.99/10)

Duplication
-----------

+-------------------------+-------+---------+-----------+
|                         |now    |previous |difference |
+=========================+=======+=========+===========+
|nb duplicated lines      |7564   |7564     |=          |
+-------------------------+-------+---------+-----------+
|percent duplicated lines |45.687 |45.687   |=          |
+-------------------------+-------+---------+-----------+



Raw metrics
-----------

+----------+-------+------+---------+-----------+
|type      |number |%     |previous |difference |
+==========+=======+======+=========+===========+
|code      |11088  |73.76 |11088    |=          |
+----------+-------+------+---------+-----------+
|docstring |990    |6.59  |990      |=          |
+----------+-------+------+---------+-----------+
|comment   |1920   |12.77 |1919     |+1.00      |
+----------+-------+------+---------+-----------+
|empty     |1034   |6.88  |1035     |-1.00      |
+----------+-------+------+---------+-----------+