[Pki-devel] [PATCH] 36-1 Revised - [PATCH] 36 - Fix for track ticket 493 in Dogtag 10.0.2 - No interpolation for password fields.

[Abhishek Koneru]

Followed the steps. Pushed to master.

--Abhishek

----- Original Message -----
From: "Endi Sukma Dewata" <edewata at redhat.com>
To: "Abhishek Koneru" <akoneru at redhat.com>
Cc: "pki-devel" <pki-devel at redhat.com>
Sent: Thursday, March 7, 2013 1:22:18 PM
Subject: Re: [PATCH] 36-1 Revised - [PATCH] 36 - Fix for track ticket 493 in Dogtag 10.0.2 - No interpolation for password fields.

On 3/7/2013 10:33 AM, Abhishek Koneru wrote:
> On discussion with Endi and Ade, it has been agreed to use an
> escape('%') character to allow usage of % in the values of the
> configuration file.
>
> If a configuration file is passed to the pkispawn script, any occurrence
> of '%' must have a '%' used with it as an escape character.
> Eg. key=abc%def, must be entered as key=abc%%def => which is read as abc
> %def. Similarly, key=abc%%def must be key=abc%%%%def
>
> I the interactive mode, the escape character is added by the code. User
> can enter the actual value without the escape character.
>
> Please review the attached patch attached for with the required changes.

ACK. Just a few things:

1. Please clean up the whitespace before push:

      git am --whitespace=fix <patch>

2. Please add a one-line title/summary in the commit log. See previous 
commit logs for example. The first line of the log message is used in 
many things such as patch filename, patch title, trac link, release 
notes, etc. so it would be nice to have a short but descriptive title.

-- 
Endi S. Dewata