[Pki-devel] [PATCH] 41 Changed the password input in pkidestroy from command line to a file. The parameter is still optional. Trac ticket #502

[Endi Sukma Dewata]

On 3/22/2013 10:16 AM, Abhishek Koneru wrote:
> Please review the attached patch which adds a -W <security domain
> password file> option replacing the -w <security domain password file>
> option in pkidestroy.

Some comments:

1. Please add a short subject line in the comment like the other patches.

2. Let's use the US spelling 'canceled' as explained in the other patch.

3. Could you find out what the strip('[\']') is used for? In any case, 
the original code strips those characters from the password. The new 
code strips those characters from the file name, not the password.

4. Please use 'with' to open the file. See:

https://fedorahosted.org/pki/ticket/560

-- 
Endi S. Dewata