[Pki-devel] [PATCH] 41 -2 Fixes for review comments for Patch 41

[Abhishek Koneru]

Please review the attached patch.

On Fri, 2013-03-22 at 10:32 -0500, Endi Sukma Dewata wrote:
> On 3/22/2013 10:16 AM, Abhishek Koneru wrote:
> > Please review the attached patch which adds a -W <security domain
> > password file> option replacing the -w <security domain password file>
> > option in pkidestroy.
> 
> Some comments:
> 
> 1. Please add a short subject line in the comment like the other patches.
Modified the subject line.
> 
> 2. Let's use the US spelling 'canceled' as explained in the other patch.
> 

Done.
> 3. Could you find out what the strip('[\']') is used for? In any case, 
> the original code strips those characters from the password. The new 
> code strips those characters from the file name, not the password.
> 
Not required when password is input using a file.
> 4. Please use 'with' to open the file. See:
> 
> https://fedorahosted.org/pki/ticket/560
> 

Used the with construct for file reading.

--Abhishek

-------------- next part --------------
A non-text attachment was scrubbed...
Name: pki-akoneru-0041-2-Change-how-the-password-is-passed-to-pkidestroy.patch
Type: text/x-patch
Size: 3049 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/pki-devel/attachments/20130325/bf9637d5/attachment.bin>