[Pki-devel] [PATCH] 252-260 Preparation for Tomcat-based TPS

[Matthew Harmsen]

On 05/30/13 09:19, Endi Sukma Dewata wrote:
> On 5/29/2013 7:50 PM, Matthew Harmsen wrote:
>> ACK the following patches:
>>
>>   * pki-edewata-0252-Reorganized-CS.cfg.in-in-RA-and-TPS.patch
>>   * pki-edewata-0253-Renamed-SECURE_PORT-into-PKI_SECURE_PORT.patch
>>   * 
>> pki-edewata-0254-Renamed-PORT-and-UNSECURE_PORT-into-PKI_UNSECURE_POR.patch
>>   * pki-edewata-0255-Renamed-SERVER_ROOT-into-PKI_INSTANCE_PATH.patch
>>   * 
>> pki-edewata-0256-Renamed-SERVER_NAME-and-PKI_MACHINE_NAME-into-PKI_HO.patch
>>   * 
>> pki-edewata-0257-Renamed-PKI_INSTANCE_ID-into-PKI_INSTANCE_NAME.patch
>>   * 
>> pki-edewata-0258-Replaced-PKI_SUBSYSTEM_DIR-with-PKI_SUBSYSTEM_TYPE.patch
>
> Pushed to master. Thanks.
>
>> *PATCHES 0259 and 0260 were NOT tested as they immediately failed
>> 'pkispawn' with the following error:*
>>
>>     pkispawn    : ERROR    ....... KeyError:  Master dictionary is
>>     missing the key called ''pki_ca_hostname''!
>>     Traceback (most recent call last):
>>        File "/sbin/pkispawn", line 420, in <module>
>>          main(sys.argv)
>>        File "/sbin/pkispawn", line 319, in main
>>          parser.compose_pki_master_dictionary()
>>        File
>> "/usr/lib/python2.7/site-packages/pki/deployment/pkiparser.py", line
>>     658, in compose_pki_master_dictionary
>>          config.pki_master_dict['pki_ca_hostname']
>>     KeyError: 'pki_ca_hostname'
>>
>> Consequently, these two patches were backed-out so that the other
>> patches could be successfully tested.
>
> New patches attached. The default parameters have been added to 
> default.cfg.
>
ACK on 0259-1 and 0260-1 after retesting.