[Pki-devel] [PATCH] 74, 75, 76, 77 Broken up patches with fixes for review comments for patch 72-3

Abhishek Koneru akoneru at redhat.com
Thu Nov 7 19:40:24 UTC 2013


Please review the attached patches. The patch 72-3 has been broken into
these patches. I will close the patch once these are ack'ed.

Patch 74 - Adds all the QE tests upstream.
Patch 75 - Adds all the scripts needed to build the task rpm.
Patch 76 - Adds the sample java tests (JUnit).
Patch 77 - Adds the README_FILE for setting up and running the tests.
           Alsi has a few minor changes w.r.t all the patches.

Review comments by Endi for 72-3 addressed here:

1. Move the test configuration file from the src folder to conf folder.
2. Provide a sample deployment config file for running the tests from
eclipse.
3. Line length should be <80 in the READ_ME Document.
4. Format the commands mentioned in README_FILE.
5. Re-arranging the sections in the README document.
6. Remove some unwanted information.

Another patch will be coming up with the build scripts for the JUnit
tests. It will also update the READ file with setting up the CI test
framework.

--Abhishek
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pki-akoneru-0074-Add-the-QE-tests-to-upstream-git.patch
Type: text/x-patch
Size: 526772 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/pki-devel/attachments/20131107/1a5e8ee9/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pki-akoneru-0075-Provide-compose-scripts-for-tests.patch
Type: text/x-patch
Size: 15114 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/pki-devel/attachments/20131107/1a5e8ee9/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pki-akoneru-0076-Added-JUnit-tests-upstream.patch
Type: text/x-patch
Size: 34505 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/pki-devel/attachments/20131107/1a5e8ee9/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pki-akoneru-0077-README-file-for-setting-up-and-running-the-tests.patch
Type: text/x-patch
Size: 8889 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/pki-devel/attachments/20131107/1a5e8ee9/attachment-0003.bin>


More information about the Pki-devel mailing list