[Pki-devel] [PATCH] TRAC Tickets #843 [20140425]

[Endi Sukma Dewata]

On 4/25/2014 10:06 PM, Matthew Harmsen wrote:
> This patch addresses the following re-opened ticket:
>
>   * PKI TRAC Ticket #843 - Incorrect CLI argument parsing
>     <https://fedorahosted.org/pki/ticket/843>
>
> I re-organized the code to make it more uniform and moved code around to
> achieve the desired results.
>
> This patch was tested on a Fedora 20 machine via the shell script called
> /*pki/base/scripts/pkiclihelp*/.
>
> Please review this patch.

Just to confirm, so all required options will now be listed in the usage 
line? We probably should update the man pages too. This can be done in a 
separate ticket.

If the number of arguments doesn't match exactly the required number, 
some commands will show messages like these:

     Error: Insufficient number of arguments specified.
     Error: No <...> specified.

If the user specifies more than the required number of arguments the 
above messages wouldn't be accurate. Probably the following generic 
message will work better?

     Error: Incorrect number of arguments specified.

Other than that it's ACKed.

-- 
Endi S. Dewata