[Pki-devel] [PATCH] 0025 first cut of tokendb management, policy, and activities

[John Magne]

Looks like a good start!

ACK

Just one optional thing:


public void tdbUpdateCertificates(TPSSubsystem tpsSubsystem, String cuid, EnrolledCertsInfo certs)
+            throws Exception {

Could we just log this in case some one calls it at this point? Obviously it is not implemented.
Perhaps a ToDo and maybe an exception thrown?


----- Original Message -----
> From: "Christina Fu" <cfu at redhat.com>
> To: pki-devel at redhat.com
> Sent: Sunday, August 3, 2014 2:33:33 PM
> Subject: Re: [Pki-devel] [PATCH] 0025 first cut of tokendb management, policy, and activities
> 
> thanks to Jack for review comments.
> Attached please find the new patch that addressed the comments.
> Christina
> 
> On 07/31/2014 05:46 PM, Christina Fu wrote:
> 
> 
> attaching the full patch this time...
> 
> On 07/31/2014 03:14 PM, Christina Fu wrote:
> 
> 
> This patch is the first cut of tokendb management, policy, and activities. It
> * adds and updates token entries in the tokendb
> * checks policies when necessarily (note: bug filed:
> https://fedorahosted.org/pki/ticket/1085
> * logs activities
> 
> Certificate related tokendb updates will be in the next patch. There may
> still be a few more activities to be logged (such as pin reset, etc, once
> complete.). Policy checks re ticket#1085 will be provided after ticket 1085
> is addressed.
> 
> Please review.
> thanks,
> Christina
> 
> 
> _______________________________________________
> Pki-devel mailing list Pki-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/pki-devel
> 
> 
> 
> _______________________________________________
> Pki-devel mailing list Pki-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/pki-devel
> 
> 
> _______________________________________________
> Pki-devel mailing list
> Pki-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/pki-devel