[Pki-devel] [Patch] Alternative CLI password methods (revised 20140807)

Matthew Harmsen mharmsen at redhat.com
Fri Aug 8 04:20:29 UTC 2014


Please review the attached patch (revised) which implements alternative 
CLI password methods to address the following PKI TRAC ticket:

  * PKI TRAC Ticket #555 - Other ways to specify CLI password
    <https://fedorahosted.org/pki/ticket/555>

This revised patch attempts to address most of the comments to the 
previous patch including:

  * made numerous man page changes
  * camelCased method names
  * changed the password routine to utilize the '=' delimiter rather
    than the ':' delimiter (more appropriate for Java)
  * consolidated the two password file routines into a single routine
    which supports 'token=password' format (as well as documenting and
    providing man page examples for how to utilize this style of file
    with a simple password)
  * removed all warning messages from the password routine
  * utilized suggestions to improve the password routine including
    replacing the use of the StringUtils.split() method with the
    String.split() method using a regex
  * rewrote password routine to handle passwords that contained the
    delimiter as a part of the password
  * ditched 'DRM'
  * removed consolidated error messages and exited immediately
  * removed the '-y' option
  * moved password prompting under the control of the pki CLI program
    for both basic and client authentication
  * removed previous changes to URI/URL
  * removed previous changes to subsystem type
  * added mutual exclusive test for "-n" (client authentication) vs.
    "-u" (basic authentication) options
  * added mutual dependency tests as needed

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/pki-devel/attachments/20140807/73c03564/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20140807-Alternative-CLI-password-methods.patch
Type: text/x-patch
Size: 24516 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/pki-devel/attachments/20140807/73c03564/attachment.bin>


More information about the Pki-devel mailing list