[Pki-devel] [PATCH] 229 - Fix enroll_cert() in cert.py to handle rejected/canceled requests

Endi Sukma Dewata edewata at redhat.com
Fri Aug 15 21:34:34 UTC 2014


On 8/15/2014 4:19 PM, Ade Lee wrote:
>   Fix enroll_cert in cert.py to account for rejected requests
>      
>      Ticket 1109
>   
> Please review.
>
> Thanks,
> Ade

ACK.

A possible improvement, we can also return objects with named attributes 
instead of tuples:

     results = cert_client.enroll_cert('caUserCert', inputs)

     for result in results:
         request = result.request
         cert = result.cert
         ...

That way we can add more attributes into the result if necessary without 
changing the client code.

-- 
Endi S. Dewata




More information about the Pki-devel mailing list