[Pki-devel] [PATCH] 411 Added CLI parameter to select message format.

[Ade Lee]

1. Typo in MainCLI.java : Mesage format

2. There appears to be no code to enforce the input to be "json or xml".
What if someone puts in "XML" or "Json" or "foo" in the CLI command
line?

3. So, it looks like we have decided to remove all the Produces/Consumes
and basically provide all servlets as XML and JSON by default.  What
that means though is that we are taking the logic of deciding which
format to return from the framework code.

I'm a little confused as to why this is needed.  Doesn't the framework
already do this work for us?

What if the client requests a format like "application/atom-xml" - and
nothing else.  If we follow your code, we will end up returning the
results in whatever format the request came in as.  This seems wrong -
we should reject the request with a code 406 (not acceptable).  And more
importantly - we should reject this prior to processing which is
presumably what the framework would do - rather than post-processing
when generating the response which is what your code does.
 
Ade

On Thu, 2014-02-20 at 11:54 -0600, Endi Sukma Dewata wrote:
> A new CLI parameter has been added to specify the format of the HTTP
> messages exchanged between the client and server. This is done by
> setting the default consumes and produces when creating the proxy.
> For this to work the @Consumes and @Produces annotations will be
> removed in the subsequent patch.
> 
> Ticket #554
> 
> _______________________________________________
> Pki-devel mailing list
> Pki-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/pki-devel