[Pki-devel] [PATCH] 0001-First-cut-at-Java-TPS-Buffer-class-and-APDU-class.patch

[Christina Fu]

First of all, this is a first cut so I am not going to be overly 
critical of little details as things will change and start to take form 
as we go on.

My comments are on some overall things:
* I see most everything are sticking to what we planned, that is, close 
to the old tps.  That's good.  it helps make things move faster.
* Nothing you (Jack) need to do now, but it's a reminder for Endi per 
our agreement on irc, you are to move your stuff under the directories 
we agreed upon.  Once Jack checks in his stuff, the tps directory is 
getting really messy, and your stuff have names that are misleading

Anyway, great Job on the first cut TPS rewrite.  My feeling is as long 
as it doesn't mess up anything ( not much additional Eclipse warnings 
unless absolutely necessary, etc.), it compiles and does what you 
claimed to do, its fine.

Jack just gave me a quick demo too.  ACK.

Christina


On 02/26/2014 07:22 PM, John Magne wrote:
> First cut at Java TPS Buffer class and APDU classes.
>
> 1. Also simple framework for working with APDU commands.
> 2. Implemented a few APDU commands in TPS_Processor class.
> 3. Can now attempt a format operation with TPS client.
>     The code can perform a few apdu's talking to the client
>     and return a success "EndOp" apdu to terminate the conversation.
> 4. APDU are being encoded/decoded properly to appease tpsclient.
>
> More info.
>
> 1. Patch is large but most of it consists of many similar apdu and msg classes.
> 2. APDU and msg classes are now bare bones and may need more work. Will address when class is needed.
> 3. A test tpsclient script call it (format.tst) to test this out is as follows:
>
> op=var_set name=ra_host value=localhost
> op=var_set name=ra_port value=8080
> op=var_set name=ra_uri value=/tps/tps
> op=token_set cuid=40906145C76224192D2B msn=0120304 app_ver=6FBBC105 key_info=0101 major_ver=1 minor_ver=1
> op=token_set auth_key=404142434445464748494a4b4c4d4e4f
> op=token_set mac_key=404142434445464748494a4b4c4d4e4f
> op=token_set kek_key=404142434445464748494a4b4c4d4e4f
> op=ra_format uid=jmagne pwd=redhat new_pin=rehat num_threads=1
> op=exit
>
> 4: Execute as follows:
>
> tpsclient < format.tst
>
>
> _______________________________________________
> Pki-devel mailing list
> Pki-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/pki-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/pki-devel/attachments/20140227/e5dd248e/attachment.htm>