[Pki-devel] [PATCH] PKI TRAC Ticket #935 - patch to BtoA and AtoB to get ARM working

[Ade Lee]

Ditto - ACK
On Wed, 2014-07-02 at 16:47 +1000, Fraser Tweedale wrote:
> On Tue, Jul 01, 2014 at 07:11:31PM -0700, Matthew Harmsen wrote:
> > Please review the attached patch (based upon what was provided by Marko Karg
> > in Bugzilla Bug #1081916 - freeipa does not install on arm architecture
> > <https://bugzilla.redhat.com/show_bug.cgi?id=1081916>) for the following
> > TRAC ticket:
> > 
> >  * PKI TRAC Ticket #935 - patch to BtoA and AtoB to get ARM working
> >    <https://fedorahosted.org/pki/ticket/935>
> > 
> > CAVEAT:  To test this, all I did was add the code to the template and build
> > on my 'x86_64' Fedora 20 machine.
> >                I extracted 'AtoB' and 'BtoA' and confirmed that they now
> > include the 'armv7l' section, and although
> >                I have attempted to request an 'arm' machine to test this
> > out, I have not yet been able to acquire a
> >                test machine, so I do not know if the 'arch' command actually
> > returns 'armv7l'.
> > 
> 
> The person who filed this bug also provided the patch and confirmed
> that it worked for them.  It would be nice to confirm it on ARM
> hardware but if we can't get some soon, it seems like it should be
> fine to merge.
> 
> Fraser
> 
> > From cc3baa89bf36250bfafbecb5736cbe4c66da9331 Mon Sep 17 00:00:00 2001
> > From: Matthew Harmsen <mharmsen at redhat.com>
> > Date: Tue, 1 Jul 2014 18:53:00 -0700
> > Subject: [PATCH] Add 'arm' architecture to tool scripts.
> > 
> > - Bugzilla Bug #1081916 - freeipa does not install on arm architecture
> > - PKI TRAC Ticket #935 - patch to BtoA and AtoB to get ARM working
> > ---
> >  base/java-tools/templates/pki_java_command_wrapper.in | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/base/java-tools/templates/pki_java_command_wrapper.in b/base/java-tools/templates/pki_java_command_wrapper.in
> > index 5d28d0e..e42d191 100644
> > --- a/base/java-tools/templates/pki_java_command_wrapper.in
> > +++ b/base/java-tools/templates/pki_java_command_wrapper.in
> > @@ -81,6 +81,10 @@ if [ "${OS}" = "Linux" ] ; then
> >          LD_LIBRARY_PATH=/usr/lib64:/lib64:${LD_LIBRARY_PATH}
> >          LD_LIBRARY_PATH=/usr/lib64/jss:${LD_LIBRARY_PATH}
> >          export LD_LIBRARY_PATH
> > +    elif [ "${ARCHITECTURE}" = "armv7l" ] ; then
> > +        LD_LIBRARY_PATH=/usr/lib:/lib
> > +        LD_LIBRARY_PATH=/usr/lib/jss:${LD_LIBRARY_PATH}
> > +        export LD_LIBRARY_PATH
> >      else
> >          invalid_architecture "${ARCHITECTURE}"
> >          exit 255
> > -- 
> > 1.9.3
> > 
> 
> > _______________________________________________
> > Pki-devel mailing list
> > Pki-devel at redhat.com
> > https://www.redhat.com/mailman/listinfo/pki-devel
> 
> _______________________________________________
> Pki-devel mailing list
> Pki-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/pki-devel