[Pki-devel] [PATCH] pki-cfu-0021-authentication-fix-fixed-issue-relating-to-authentic.patch

[Christina Fu]

Thanks to jack for the review and test from ESC.

Addressed and pushed to master per conditional ACK:
commit d088bab2e335d266c465c333dc3f7c316c30bd46

Christina

On 07/24/2014 02:54 PM, John Magne wrote:
> Looks fine:
>
> Conditional ACK based on minor suggestion:
>
>
> Note the following:
>
> +            String name;
> +            if (extendedLogin == true)
> +                name = auth.getCredMap_extlogin(cred);
> +            else
> +                name = auth.getCredMap_login(cred);
>
> Note we have two methods each for the two different kinds of credMaps
> for both setters and getters.
>
> My quick suggestion is to just make one getter and setter and pass in
> the "extendedLogin" boolean and let the internal method decide what to do.
>
> You have another method already that uses this, it may make things a bit more uniform.
>
>
>
>
> ----- Original Message -----
> From: "Christina Fu" <cfu at redhat.com>
> To: pki-devel at redhat.com
> Sent: Thursday, July 24, 2014 11:46:38 AM
> Subject: Re: [Pki-devel] [PATCH]	pki-cfu-0021-authentication-fix-fixed-issue-relating-to-authentic.patch
>
> patch attached.
>
> On 07/24/2014 11:37 AM, Christina Fu wrote:
>> authentication fix: fixed issue relating to authentication that
>> switching between ESC and tpsclient needs to change CS.cfg param value
>> and restart TPS.  This fix makes the issue go away.
>> The actual issue is the differences between "loginRequest" and
>> "extendedLoginRequeest".
>>
>> thanks,
>> Christina
>>
>> _______________________________________________
>> Pki-devel mailing list
>> Pki-devel at redhat.com
>> https://www.redhat.com/mailman/listinfo/pki-devel
>
> _______________________________________________
> Pki-devel mailing list
> Pki-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/pki-devel