[Pki-devel] <pki-devel> [PATCH] 0006- Further work on TPS Processor, format operation.patch

Endi Sukma Dewata edewata at redhat.com
Thu Mar 20 01:32:15 UTC 2014


Just one more comment, in TPSSession read(), write(), process(), and 
probably some methods in TPSProcessor, we can actually catch the 
IOException, log the message, then throw the original exception object. 
No need to create a new IOException wrapper because we aren't changing 
the exception type.

   try {
       ...
   } catch (IOException e) {
       CMS.debug(...);
       throw e;
   }

Everything else is good, and the code is a lot easier to read. ACK.

-- 
Endi S. Dewata




More information about the Pki-devel mailing list