[Pki-devel] [PATCH] Refactored CertRevokeRequest and CertUnrevokeRequest classes in Dogtag 10

Abhishek Koneru akoneru at redhat.com
Mon May 5 10:44:12 UTC 2014


Please review the patch which refactors the CertRevokeRequest class and
removes the CertUnrevokeRequest class in Dogtag 10. Description of the
patch:

There seems to be no use of the requestID parameter in both revoke
and unrevoke request. Removed requestID attribute in CertRevokeRequest
remove the class CertUnrevokeRequest.

Also made changes in RevocationProcesor to use the requestID of the
request created in it.

The setRequestID() is being called in the DoRevoke and DoUnRevoke
servlets.
Removed the call and a function auditRequesterId in both the classes.

The auditRequestorId method tries to get a "requestID" stored as a INPUT
field
in the reasonToRequest page. The ReasonToRevoke class which generates
this page does not set the value.

* This patch is required for patch 92. The unrevoke_request method in
CertClient on the python side will not work without this patch.

--Abhishek
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pki-akoneru-0091-Removed-requestID-parameter-usage-in-un-revoke-reque.patch
Type: text/x-patch
Size: 19395 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/pki-devel/attachments/20140505/4c895f35/attachment.bin>


More information about the Pki-devel mailing list